Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

om ci: Run nix flake check #200

Closed
srid opened this issue Aug 5, 2024 · 1 comment · Fixed by #229
Closed

om ci: Run nix flake check #200

srid opened this issue Aug 5, 2024 · 1 comment · Fixed by #229
Labels
enhancement New feature or request
Milestone

Comments

@srid
Copy link
Member

srid commented Aug 5, 2024

Not all checks are done by building a derivation (what nixci build does currently).

For eg., nix flake check tests for unknown properties in templates.* and errors out:

https://github.com/NixOS/nix/blob/babfd0cd99012df9d645d38e47fa31d049bf01d8/src/nix/flake.cc#L550-L554

image

The above will not be caught by nixci build.

Do we care to support this niche case, though?

--

More generally, nix flake check does a bunch of "Evaluation checks":

image
@srid srid added the enhancement New feature or request label Aug 5, 2024
@srid srid added this to the v2 milestone Aug 5, 2024
@srid
Copy link
Member Author

srid commented Aug 5, 2024

I wonder if we can decouple these checks through flake-schemas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant