Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(pr-template): add API contract changes and update contributing docs with recent labels #936

Merged
merged 2 commits into from
Apr 20, 2023

Conversation

SanchithHegde
Copy link
Member

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation

Description

This PR updates the PR template with a checklist entry for API contract changes, and the contributing guidelines with recently added labels.

Motivation and Context

This should help with identifying API contract breaking changes in a better manner.

How did you test it?

N/A

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@SanchithHegde SanchithHegde added C-doc Category: Documentation updates S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Apr 20, 2023
@SanchithHegde SanchithHegde self-assigned this Apr 20, 2023
@SanchithHegde SanchithHegde requested a review from a team as a code owner April 20, 2023 19:20
@jarnura jarnura added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Apr 20, 2023
@jarnura jarnura added this pull request to the merge queue Apr 20, 2023
Merged via the queue into main with commit 3e2a7ea Apr 20, 2023
@SanchithHegde SanchithHegde deleted the pr-template-api-contract branch April 21, 2023 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-doc Category: Documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants