-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update .gitignore
#1327
Update .gitignore
#1327
Conversation
This PR moves over the changes from #1112
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with a minor suggestion for improving the accuracy of a comment.
BTW, I think it would be good to include proposed CHANGELOG updates in PRs, so they can be reviewed too. Perhaps the theme docs should mention |
Co-authored-by: Peter Mosses <18308236+pdmosses@users.noreply.github.com>
That sounds like a good idea to me! I can do this for all future PRs that I author as well. In this case though, I don't think we should include this in the changelog; this isn't a user-facing change (the As a result,
Since this isn't user-facing, I'm not sure if it's relevant; or, did you mean as a "here are defaults we recommend"? I'll open a similar PR in just-the-docs-template, which might serve as a better place for that to live in. |
Many existing users of JTD may have an outdated One way to draw attention to it might be to update the template for submitting JTD bug issues. In general, I tend to give low priority to issues that don't include a link to a repo where I can see the |
Great idea! I need to write up a few of the items we've discussed anyways, so I'll tag that on to my list of repository improvements. I agree that the current set of issue templates leaves some things to be desired. |
Have opened #1346! |
This PR moves over the changes from #1112, namely making the
.gitignore
more descriptive and bringing it to parity with the recommendations from Jekyll.