Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] With multi-m2ts mpls, subtitles drift out of sync #262

Closed
jcdr428 opened this issue Mar 27, 2020 · 4 comments
Closed

[bug] With multi-m2ts mpls, subtitles drift out of sync #262

jcdr428 opened this issue Mar 27, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@jcdr428
Copy link
Collaborator

jcdr428 commented Mar 27, 2020

See notification of bug here https://forum.doom9.org/showthread.php?p=1905010#post1905010

@FilipeAmadeuO
Copy link

The solution maybe would be for tsmuxer to mantain the multi m2ts (one mpls) struture and not join the multi m2ts in one big m2ts.
This way we could build one by one m2ts and keep the exact same struture as before.

@jcdr428
Copy link
Collaborator Author

jcdr428 commented Mar 27, 2020

@FilipeAmadeuO that would be nice, however this would be a substantial rewrite of the code as currently tsMuxer is set to write only one m2ts, clpi, mpls, and pre-defined index.bdmv and MovieObject.bdmv. Plus code writing for the ATCd seamless branching etc.

@FilipeAmadeuO
Copy link

@FilipeAmadeuO that would be nice, however this would be a substantial rewrite of the code as currently tsMuxer is set to write only one m2ts, clpi, mpls, and pre-defined index.bdmv and MovieObject.bdmv. Plus code writing for the ATCd seamless branching etc.

OK. Understood. Maybe a improvement for the future.

@justdan96 justdan96 added the bug Something isn't working label Mar 28, 2020
@lonecrane
Copy link
Contributor

lonecrane commented Mar 29, 2020

Wonderful!
According to the tests on UHD BD 'WALL E', which consists of 43 m2ts segments, now all the subtitles are demuxed very precisely.
Take for example the stream of pid 0x12a0, the internal timestamp presented by player is:
fig 1-2
The Demuxed timestamp with the latest version matches very precisely, appearing only 3ms advance:
fig 1-1
The demuxed timestamp with the previous version w64-nightly-2020-03-25--01-12-53 delays 358ms:
fig 1-3
Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants