-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration Tests not working with latest goaws #494
Comments
It seems to be picking up the |
I had this problem locally a week or so ago actually running it locally on my work laptop because Docker is messed up on it. In my case I had to explicitly tell it were the |
#495 works around this by pinning the version, but we should look into what's wrong and fix it or raise an issue against goaws. |
Agreed, that was just to unblock us. I think it is finding the config but selecting the wrong env. I'll create an image with our own config and see I can get it working. Probably tonight |
@slang25 I guess this is done now? |
Thanks, fixed in #496 |
The latest version of goaws has been pushed to docker hub, it contains some really nice fixes (we might be able to enable more tests). However currently it has broken our tests, so we either need to pin the version or fix them.
See here:
https://travis-ci.org/justeat/JustSaying/jobs/473402360
I'll do some investigating.
The text was updated successfully, but these errors were encountered: