Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration Tests not working with latest goaws #494

Closed
slang25 opened this issue Dec 29, 2018 · 6 comments
Closed

Integration Tests not working with latest goaws #494

slang25 opened this issue Dec 29, 2018 · 6 comments

Comments

@slang25
Copy link
Member

slang25 commented Dec 29, 2018

The latest version of goaws has been pushed to docker hub, it contains some really nice fixes (we might be able to enable more tests). However currently it has broken our tests, so we either need to pin the version or fix them.

See here:
https://travis-ci.org/justeat/JustSaying/jobs/473402360

I'll do some investigating.

@slang25
Copy link
Member Author

slang25 commented Dec 30, 2018

It seems to be picking up the Local environment config, not Dev (see here), so we are getting queue urls with ...goaws.com/... in.

@martincostello
Copy link
Member

I had this problem locally a week or so ago actually running it locally on my work laptop because Docker is messed up on it.

In my case I had to explicitly tell it were the goaws.yaml file was in WSL as it didn't seem to be picking the location up for itself, so then it was generating queue URIs like http://:/foo, and causing exceptions from Uri.ctor().

@martincostello
Copy link
Member

#495 works around this by pinning the version, but we should look into what's wrong and fix it or raise an issue against goaws.

@slang25
Copy link
Member Author

slang25 commented Jan 2, 2019

Agreed, that was just to unblock us. I think it is finding the config but selecting the wrong env. I'll create an image with our own config and see I can get it working. Probably tonight

@martincostello
Copy link
Member

@slang25 I guess this is done now?

@slang25
Copy link
Member Author

slang25 commented Jan 4, 2019

Thanks, fixed in #496

@slang25 slang25 closed this as completed Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants