Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning and potential issues when saving while script is running #8

Open
fmagin opened this issue May 19, 2019 · 1 comment
Open

Warning and potential issues when saving while script is running #8

fmagin opened this issue May 19, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request reproduced Issue has been reproduced by maintainers

Comments

@fmagin
Copy link
Contributor

fmagin commented May 19, 2019

When attempting to save (File->Save or Ctrl+s) when the bridge is running Ghidra issues a warning that the program is currently being modified by a python script and any changes made by that script will be lost and potential future errors might occur.

I think currently this is an inherent limitation of the design (as a script instead of maybe an extension). This might not actually break anything if the bridge isn't used to modify anything. Some temporary fix would be to fix the issue that the script can't be canceled and restarted without restarting Ghidra (due to the address not being freed), so it could just be canceled, program could be saved and restarted.

@justfoxing justfoxing added enhancement New feature or request reproduced Issue has been reproduced by maintainers labels May 20, 2019
@justfoxing justfoxing self-assigned this May 20, 2019
@justfoxing
Copy link
Owner

Yup, that's a thing. The next thing I was thinking of, after landing the interactive fixes, was writing a Ghidra plugin to provide controls for starting/stopping correctly.

@justfoxing justfoxing added this to the Plugin Integration milestone Jul 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request reproduced Issue has been reproduced by maintainers
Projects
None yet
Development

No branches or pull requests

2 participants