Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time to release a new version? #47

Closed
siong1987 opened this issue Nov 4, 2014 · 15 comments
Closed

time to release a new version? #47

siong1987 opened this issue Nov 4, 2014 · 15 comments

Comments

@siong1987
Copy link

the current version in rubygems doesn't seem to support sidekiq 3. i think it is the right time to upgrade the version on rubygems to the latest?

@mtthwhggns
Copy link

You possibly know this @siong1987 , but for reference for anyone who finds this and is looking for a solution;

If you install the gem directly from the GitHub source, it loads the most recent version here, which is compatible with sidekiq 3, and seems to work fine.

Instead of

gem 'autoscaler'

Just use

gem 'autoscaler', :git => 'git://github.com/JustinLove/autoscaler.git'

@siong1987
Copy link
Author

@MatthewEHiggins that's exactly what i am doing now. but since sidekiq 3.0 has been out for a while, i think that it's time to release a new version. :)

@Ganasist
Copy link

So does it work with:
gem 'autoscaler', :git => 'git://github.com/JustinLove/autoscaler.git'

I just tried to set it up and it did not seem to affect worker number. Even after I triggered a job and waited a few minutes the workers seemed to be running as usual.

Rails 4.2
sidekiq 3.2.4

@mtthwhggns
Copy link

It seemed to work fine for me when I did it that way.

Do you have any scheduled jobs at all? As they appear to make workers stay running in my set up?

@Ganasist
Copy link

No scheduled jobs. I thought maybe having sidekiq/web enabled was the problem, so I disabled it and no go.... BUT I should be clear that I wasn't using:
gem 'autoscaler', :git => 'git://github.com/JustinLove/autoscaler.git'

I was using:
gem 'autoscaler'

I figured maybe Heroku blocked Autoscaler (is that possible?) because they offer a paid add-on that does something similar now:
https://addons.heroku.com/adept-scale

@mtthwhggns
Copy link

I see!

I think it's very unlikely Heroku has blocked it, and if they did, it would probably give an error message to let you know that!

If you're using SideKiq 3, how were you able to install the gem without loading the GitHub version directly? When I tried that, it wouldn't bundle/build at all? Have you double-checked the other set-up steps from readme?

In my setup (same app in staging/production) the staging app correctly scales right down to zero (using, but my production app almost always has something scheduled, so is always running at least one dyno, even when they are scheduled for hours/days in the future.

@Ganasist
Copy link

Ok I just tried the exact same thing with the GitHub version and it works, great! I'm using it in production, since in Staging I have Sidekiq running within the Unicorn process (to save costs and run on one dyno).

Its unfortunate that scheduled jobs 'break' this functionality. I'll have to keep that in mind in the future!

Thanks for your help!

@Ganasist
Copy link

I spoke too soon. The worker spun down, but when I triggered a new background task it didn't spin back up again! Oh well, almost got it. Luckily it wasn't critical that I got this working, it would have been icing on the cake...

@claudiob
Copy link
Contributor

claudiob commented Feb 9, 2015

@JustinLove great job with this project!

I agree that it would be nice to have a new version of the gem on Rubygems.org

What's your opinion on that?

@devill
Copy link

devill commented Mar 15, 2015

+1 for new release! It looks a bit like a hack to add the github repo into the Gemfile

@tmaier
Copy link
Contributor

tmaier commented May 8, 2015

@JustinLove: Sidekiq 3 support seems not to be high on your priority list, but it would be really great if you could cut out a new gem for us :)

@JustinLove
Copy link
Owner

CC @bkudria #32 ?

@warmwaffles
Copy link

Any news on cutting a new release to support sidekiq 3?

@JustinLove
Copy link
Owner

Master is caught up with pull requests and issues I intend to implement. I still don't have an application for this and am relying on unit tests. Anybody with an application care to smoke test it?

@claudiob
Copy link
Contributor

I just tried in production (on Heroku) and it works. If you cut a gem at this version, I'm going to point at it.

Thanks again for your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants