Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webp images missing #24

Closed
pableu opened this issue Nov 20, 2020 · 2 comments
Closed

Webp images missing #24

pableu opened this issue Nov 20, 2020 · 2 comments
Assignees

Comments

@pableu
Copy link

pableu commented Nov 20, 2020

There are a multitude of videos that do not have the webp thumbnail.

Paul Irish even mentions the unreliability in his code:

    * Lo, the youtube placeholder image!  (aka the thumbnail, poster image, etc)
    * There is much internet debate on the reliability of thumbnail URLs. Weak consensus is that you
    * cannot rely on anything and have to use the YouTube Data API.

https://github.com/paulirish/lite-youtube-embed/blob/a927d63781883088c185cb69a0baade52732ab3e/src/lite-yt-embed.js#L22

I have not spent a lot of time with this, but I think there's no good and simple solution for this that includes webp. The easy and pragmatic solution is probably to simply forgo the webp version.

@justinribeiro justinribeiro self-assigned this Nov 30, 2020
@13111y
Copy link

13111y commented Jun 15, 2021

I'm using it within PageFly on Shopify and it serves .webP facades fine. 'A' grade on GTMetrix :D
Screenshot 2021-06-15 at 17 03 16

@justinribeiro
Copy link
Owner

Closing as this component has JPG fallback in the picture element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants