Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature list is omitting features after listing some stylistic sets #63

Closed
kontur opened this issue Mar 16, 2020 · 5 comments
Closed

Feature list is omitting features after listing some stylistic sets #63

kontur opened this issue Mar 16, 2020 · 5 comments
Labels
bug Something isn't working

Comments

@kontur
Copy link
Contributor

kontur commented Mar 16, 2020

Hey,

I've noticed with one font that some features seem to be missing and tested with a few different fonts (otf, ttf, variable font, more features, less features, only certain features). It seems something in the listing of stylistic sets is "breaking" and all features following alphabetically later are dropped from the features listing. This seems to happen during or after the listing of stylistic sets only, afaik, but oddly enough the first ssXX are listed still, but the rest of ssXX and all features after (like zero).

To have a reproducible case I am viewing this font with FontGoogles Version 1.1.4.

Stylistic sets as listed in Adobe InDesign CC 2020:
Screenshot 2020-03-16 at 12 01 24

Versus the feature listing in FG:
Screenshot 2020-03-16 at 12 01 36

I am wondering if the culprit has something to do with the list of ssXX after the first not defined set, e.g. this font has ss01ss04 then has no ss05 but has ss06—and seems to omit all after ss04. Equally another font I tested has ss01 and ss02 but has no ss03 but does have ss04 and omits everything after ss02. Or maybe this is incidental.

@justvanrossum
Copy link
Owner

Thanks, sounds like a bug. I'll look into it.

@justvanrossum
Copy link
Owner

It's a bug in uharfbuzz: harfbuzz/uharfbuzz#31

@kontur
Copy link
Contributor Author

kontur commented Mar 16, 2020

Nifty find, and so quick 👍
Yep, looks like all three fonts I've replicated it with seem to cut off exactly after 24 feature tags, it just incidentally happens to be mid-way of the stylistic sets each time.

@justvanrossum
Copy link
Owner

Fixed in version 1.1.6.

@kontur
Copy link
Contributor Author

kontur commented Mar 18, 2020

Can confirm this works correctly with all fonts I encountered the problem with. Big thanks for the quick fix 👍

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants