Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all features reported by ot_layout_language_get_feature_tags() due to 24 max #31

Closed
justvanrossum opened this issue Mar 16, 2020 · 2 comments · Fixed by #32
Closed

Comments

@justvanrossum
Copy link
Collaborator

cdef unsigned int feature_count = 24

Also ot_layout_script_get_language_tags():

cdef unsigned int language_count = 24

And ot_layout_table_get_script_tags():

cdef unsigned int script_count = 24

This is the root cause of justvanrossum/fontgoggles#63

Funny thing: I just noticed this limitation in uharfbuzz a couple of days ago and wondered when we'd see a real-world report, and here we are :)

I'll try to write a fix.

@khaledhosny
Copy link
Collaborator

khaledhosny commented Mar 16, 2020

If mallocing is not desired, one can keep looping until there are no more items to get. Here is an example https://github.com/ufyTeX/luaharfbuzz/blob/master/src/luaharfbuzz/face.c#L98-L119

@justvanrossum
Copy link
Collaborator Author

Thanks, that's exactly the approach I had in mind.

@justvanrossum justvanrossum reopened this Mar 16, 2020
justvanrossum added a commit that referenced this issue Mar 16, 2020
Don't hardcode a maximum number of tags (fix for #31)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants