Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't remove :handler from match-context #211

Open
daaku opened this issue Oct 31, 2021 · 0 comments
Open

Don't remove :handler from match-context #211

daaku opened this issue Oct 31, 2021 · 0 comments

Comments

@daaku
Copy link

daaku commented Oct 31, 2021

I traced back the history to 92a2263 but it's unclear why :handler is removed from the match-context (along with other info which unlike this is present in the request). I wanted my bidi.ring/Ring implementation to be able to access this match information, and the only way I can do so is to copy paste make-handler and not drop this key. Does it seem reasonable to keep this key in the match-context?

It's a trivial PR if this is acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant