Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

touchmove draws when touch point is outside the grid #23

Closed
xgbuils opened this issue Sep 24, 2018 · 0 comments · Fixed by #24
Closed

touchmove draws when touch point is outside the grid #23

xgbuils opened this issue Sep 24, 2018 · 0 comments · Fixed by #24

Comments

@xgbuils
Copy link
Contributor

xgbuils commented Sep 24, 2018

Hi,

I introduced a defect in #20 related to touchmove. If you start touching in the grid and moving to the right out of grid boundaries, some cells of the grid are painted. This is because horitzontal coordinate should be lower than columns and this validition is not performed.

Cheers!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix drawing when touching outside the grid xgbuils/pixel-art-react
1 participant
@xgbuils