Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix touchmove drawing behaviour #20

Merged
merged 4 commits into from Sep 22, 2018
Merged

Conversation

xgbuils
Copy link
Contributor

@xgbuils xgbuils commented Sep 21, 2018

Hi!

This is a solution for fixing touch drawing behaviour. Notice that there are the changes about #19 . This is because now I'm doing the PR to develop branch and develop branch is not syncronyzed from master yet (sorry, yesterday I didn't notice that I made the PR to master branch).

develop branch should be syncronized to see the changes correctly.

Cheers!

@jvalen jvalen merged commit 15dc14a into jvalen:develop Sep 22, 2018
@jvalen
Copy link
Owner

jvalen commented Sep 22, 2018

Merged! Excellent work @xgbuils

All the changes are within the develop branch, I'll sync it with master soon.

I'd like to let you know that I've done a couple of fixes:

  • The first one (e44e118) is related to the mouseup (mouseUp is not working outside grid panel #18 ) solution, which introduced a bug, making the user unable to click on any element rather than the pixel grid on mobile
  • The second one (2b88465) will avoid the user scroll while drawing on mobile, it might not work properly on Safari though since touch-action is not supported.

Thank you!

@xgbuils xgbuils deleted the fix-touchmove branch September 22, 2018 01:42
xgbuils added a commit to xgbuils/pixel-art-react that referenced this pull request Sep 22, 2018
@xgbuils
Copy link
Contributor Author

xgbuils commented Sep 22, 2018

Hi @jvalen

Sorry for the inconvenience and thanks for the quick fixes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants