mot-object: does not save object to filesystem

[athoik]

Hi,

It seems that mot-object doesn't save images to filesystem any more.

dab-cmdline/library/src/backend/data/mot/mot-object.cpp

Lines 163 to 173 in 252ab7f

	// MOT slide, to show
	if (name == "")
	realName = "no name";
	else
	realName = name;
	// FILE * temp = fopen (realName. c_str (), "w");
	// fwrite (result.data (), 1, result. size (), temp);
	if (motdataHandler != nullptr)
	motdataHandler (realName, contentsubType, ctx);
	}

It was disabled on: d858f4f

(but before disable, it was written on working directory, instead of /tmp)

I restore it like this:

https://github.com/satdreamgr/dab-cmdline/blob/dev/library/src/backend/data/mot/mot-object.cpp#L164-L176

Obviously if there is no motdataHandler we can simply return immediately from handleComplete.

Restore this functionality?

[JvanKatwijk]

I do not have a problem with that, the reason the objects were not saved was a user request to stop automatic saving. Actually I think it should be done in the user handler, rather than from deep inside the code I'll have a good look Op di 14 apr. 2020 om 23:13 schreef Athanasios Oikonomou < notifications@github.com>:

…

Hi, It seems that mot-object doesn't save images to filesystem any more. https://github.com/JvanKatwijk/dab-cmdline/blob/252ab7fd2665e1ebd55fa7e887d20df4c1e1b2fa/library/src/backend/data/mot/mot-object.cpp#L163-L173 It was disabled on: d858f4f <d858f4f> (but before disable, it was written on working directory, instead of /tmp) I restore it like this: https://github.com/satdreamgr/dab-cmdline/blob/dev/library/src/backend/data/mot/mot-object.cpp#L164-L176 Obviously if there is no motdataHandler we can simply return immediately from handleComplete. Restore this functionality? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#66>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACCPHQEABKS27VD7NLJYWZLRMTGYHANCNFSM4MIB4J3Q> .

-- Jan van Katwijk

[JvanKatwijk]

I changed the code:
if a handler is present then the object is written as a file in /tmp
if no handler is preset, object is ignored

[athoik]

And that perfectly makes sense! Thank you!