Next #5
Open
Next #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and lib/llvm/core.rb to reflect this change, and removed references to lib/llvm/target.rb, as it was no longer needed.
…/gempackagetask. Added the check_bindings target, which will use objdump to collect symbols from libLLVM and compare them to the symbols defined in the bindings module.
…Instruction (IndirectBr) to use it.
…be bound to Ruby code using FFI.
Removed the Makefile and replaced it with one generated by the new extconf.rb file. Added the new extconf.rb file to the gem specification. Corrected a typo in the build.rb file.
|
Is there any further work that needs to be done before you can pull this? |
|
@chriswailes I believe I've ported all your changes: ruby-llvm/ruby-llvm#16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are all of the changes put into individual commits. The issue with the protected method in execution_engine.rb was an unfortunate side effect of me learning git. I thought I had removed that change.
The ibr instruction's optional parameter isn't arbitrary (at least here it isn't): the value is the same default value as found in the C++ API. I've subclassed Instruction and provided a method (and alias) for calling LLVMAddDestination.