Two-factor refactoring. #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull out totp code into separate class and make that class settable as part of initial app config. Add stubs for getting and setting the last_counter so folks can easily add replay-attack protection. Also - this will be part of the new passwordless implementation - so wanted these pieces reusable. Add calc_username() to UserMixin which calculates an appropriate username based on the IDENTITY_ATTRIBUTES. This is useful in forms, urls etc (and came from the recent PR to fix the two-factor qrcode URI). Modify the twofactor email templates to use this rather than assuming that all user models have 'username'. Very minor improvements to localization of some fields in 2FA forms - the submit buttons label should come from the form definition - not be hard-coded (english).
|
Looking good from what I see |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull out totp code into separate class and make that class settable as part
of initial app config.
Add stubs for getting and setting the last_counter so folks can easily add
replay-attack protection.
Also - this will be part of the new passwordless implementation - so wanted
these pieces reusable.
Add calc_username() to UserMixin which calculates an appropriate username based on
the IDENTITY_ATTRIBUTES. This is useful in forms, urls etc (and came from
the recent PR to fix the two-factor qrcode URI).
Modify the twofactor email templates to use this rather than assuming that
all user models have 'username'.
Very minor improvements to localization of some fields in 2FA forms - the submit
buttons label should come from the form definition - not be hard-coded (english).
@Kishi85 If you have a few minutes to look this over - that'd be great.