Unified sign in #257
Merged
Unified sign in #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a completely new implementation that leverages much of the 2FA work to enable email, sms, and authenticator app options for signing in without a password. This really is a unified/general login mechanism - using a single form can login with identity/passcode. Where identity is defined by USER_IDENTITY_ATTRIBUTES and the new USER_IDENTITY_MAPPINGS used to order and match to find the appropriate field to look up. The passcode can be password, or a code received via email, sms, authenticator as specified in the PL_ENABLED_METHODS Functionally complete with still a bunch of TODOs as outlined at the top of passwordlessv2.py Minor refactoring of some configuration variables that are now shared between 2FA and passwordless.
This is a completely new implementation that leverages much of the 2FA work to enable email, sms, and authenticator app options for signing in without a password. This really is a unified/general login mechanism - using a single form can login with identity/passcode. Where identity is defined by USER_IDENTITY_ATTRIBUTES and the new USER_IDENTITY_MAPPINGS used to order and match to find the appropriate field to look up. The passcode can be password, or a code received via email, sms, authenticator as specified in the PL_ENABLED_METHODS Functionally complete with still a bunch of TODOs as outlined at the top of passwordlessv2.py Minor refactoring of some configuration variables that are now shared between 2FA and passwordless.
This is a completely new implementation that leverages much of the 2FA work to enable email, sms, and authenticator app options for signing in without a password. Using a single form can login with identity/passcode. Where identity is defined by USER_IDENTITY_ATTRIBUTES and the new USER_IDENTITY_MAPPINGS used to order and match to find the appropriate field to look up. The passcode can be password, or a code received via email, sms, authenticator as specified in the US_ENABLED_METHODS Functionally complete with still a bunch of TODOs as outlined at the top of unified_signin.py Minor refactoring of some configuration variables that are now shared between 2FA and unified sign in.
This is a completely new implementation that leverages much of the 2FA work to enable email, sms, and authenticator app options for signing in without a password. Using a single form can login with identity/passcode. Where identity is defined by USER_IDENTITY_ATTRIBUTES and the new USER_IDENTITY_MAPPINGS used to order and match to find the appropriate field to look up. The passcode can be password, or a code received via email, sms, authenticator as specified in the US_ENABLED_METHODS Functionally complete with still a bunch of TODOs as outlined at the top of unified_signin.py Minor refactoring of some configuration variables that are now shared between 2FA and unified sign in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a completely new implementation that leverages much of the
2FA work to enable email, sms, and authenticator app options for
signing in without a password.
Using a single form can login with identity/passcode.
Where identity is defined by USER_IDENTITY_ATTRIBUTES and the new
USER_IDENTITY_MAPPINGS used to order and match to find the appropriate
field to look up.
The passcode can be password, or a code received via email, sms, authenticator
as specified in the US_ENABLED_METHODS
Functionally complete with still a bunch of TODOs as outlined at the
top of unified_signin.py
Minor refactoring of some configuration variables that are now shared
between 2FA and unified sign in.