Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for multiple walkthroughs #3

Closed
craig0990 opened this issue Jul 30, 2014 · 3 comments
Closed

Add support for multiple walkthroughs #3

craig0990 opened this issue Jul 30, 2014 · 3 comments
Assignees
@craig0990
Labels
enhancement in progress
Milestone
Version 2

Comments

@craig0990
Copy link
Collaborator

The plugin does not currently allow multiple walkthroughs on a single page.

This is desirable for:

  • Single-page apps
  • Atomic walkthroughs for specific feature sets

Desired syntax:

$('selector').pagewalkthrough('...');

Necessarily deprecates the $.pagewalkthrough('...') syntax. Alternatively, this could default to the <body> element for backwards compatibility.
@jwarby
Copy link
Owner

jwarby commented Jul 30, 2014

Personally, I think the static $.pagewalkthrough function is just confusing. I would opt for binning it off entirely - we're bumping to version 2, so we don't need to maintain full backwards compatibilty, provided we fully document these kind of breaking changes in the README.

@craig0990
Copy link
Collaborator Author

Agreed

@craig0990
Copy link
Collaborator Author

May actually already support this:

https://github.com/warby-/jquerypagewalkthrough.github.com/blob/7456686fd6520b09fce7726af4dc9670284d54dc/plugins/jquery.pagewalkthrough-1.1.0.js#L53-58

Appears to use the element ID as a unique selector. Hardly ideal.

@jwarby jwarby added this to the Version 2 milestone Jul 30, 2014
@craig0990 craig0990 self-assigned this Jul 31, 2014
@craig0990 craig0990 mentioned this issue Jul 31, 2014
Closed
craig0990 pushed a commit that referenced this issue Aug 4, 2014
Merge branch 'issue/#3'
020a9d4
craig0990 pushed a commit that referenced this issue Aug 8, 2014
Initial work-in-progress for multiple walkthrough support [#3]
2344ad7
craig0990 pushed a commit that referenced this issue Aug 8, 2014
Enable strict mode and fix obvious errors caught by it (duplicate key…
c48bc0a 
…s, undefined variable) [#3]
craig0990 pushed a commit that referenced this issue Aug 8, 2014
Merge branch 'issue/#3'
11429ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@craig0990 craig0990

Labels
enhancement in progress
Projects
None yet
Milestone
Version 2
Development

No branches or pull requests
2 participants
@craig0990 @jwarby