Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot mouse binding (Right) to use copy action #1963

Closed
LinkTed opened this issue Jan 1, 2019 · 4 comments
Closed

Cannot mouse binding (Right) to use copy action #1963

LinkTed opened this issue Jan 1, 2019 · 4 comments

Comments

@LinkTed
Copy link

LinkTed commented Jan 1, 2019

Hi,
i cannot use the action copy with the mouse binding right. Here a snippet of my config file:

mouse_bindings:
   - { mouse: Right,  action: Copy }

Which operating system does the issue occur on?
Linux 4.20.0-arch1-1-ARCH (Arch Linux)

If on linux, are you using X11 or Wayland?
X11 (i3) and Wayland (sway)

The version is: 0.2.4

Thank you for your attention

@chrisduerr
Copy link
Member

This is likely because the selection gets removed when right-clicking. So the selection is first removed and then copied, which leads to an empty selection.

@nixpulvis
Copy link
Contributor

nixpulvis commented Jan 1, 2019

Just reading the code, I'm wondering if the order of this function call could be simply moved up above?

https://github.com/jwilm/alacritty/blob/c47c52d8444bb30e72fc11a99e7ab34561f09740/src/input.rs#L662

@chrisduerr
Copy link
Member

@nixpulvis I don't see how that would break anything, assuming that it does indeed solve the problem. Mouse bindings getting triggered should have no side effects.

@chrisduerr
Copy link
Member

This has been fixed in #1965.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants