Current status of play view/form/template (non-functional) #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbelderbos
reviewed
Jan 8, 2024
|
|
||
| def __init__(self, *args, **kwargs): | ||
| matching_tunes_queryset = kwargs.pop("matching_tunes_queryset", None) | ||
| super(PlayForm, self).__init__(*args, **kwargs) |
There was a problem hiding this comment.
Py 2, starting v3 you can do super()
| play_form = PlayForm(initial={"suggested_tune": suggested_tune}) | ||
| return render(request, "tune/play.html", locals()) | ||
| # play_form = PlayForm([tune.id for tune in tunes]) | ||
| suggested_tune = tunes.first() |
There was a problem hiding this comment.
Where I said tunes[0] previously, first() and last() also work
| matching_tunes_queryset = RepertoireTune.objects.filter(id__in=matching_tunes) | ||
| play_form = PlayForm( | ||
| request.POST or None, | ||
| initial={"matching_tunes": matching_tunes}, |
There was a problem hiding this comment.
Need to run this, so here you want to form pre-populated ...
| if choice == "Play!": | ||
| suggested_tune.last_played = timezone.now() | ||
| suggested_tune.save() | ||
| messages.success(request, f"Played {suggested_tune.tune.title}!") | ||
| else: | ||
| print(f"playform invalid: {play_form.errors}") |
There was a problem hiding this comment.
Error should show up in the form in the template?
| @@ -18,7 +18,10 @@ | |||
| <p> Okay? </p> | |||
| <form method="post" action="{% url 'tune:tune_play' %}"> | |||
| {% csrf_token %} | |||
| {{ play_form.suggested_tune }} | |||
| {% for value in play_form.initial.matching_tunes %} | |||
There was a problem hiding this comment.
This can not be done with the model form out of the box?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.