Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a SelectFunc(filter) selector that just delegates to the given filter function #9

Open
jwodder opened this issue Apr 27, 2024 · 2 comments
Labels
c:selectors enhancement New feature or request therefor

Comments

@jwodder
Copy link
Owner

jwodder commented Apr 27, 2024

This would let users create custom selectors (so that, say, they can combine their logic with other selectors) without having to create a custom Selector subclass.

@jwodder jwodder added enhancement New feature or request therefor c:selectors labels Apr 27, 2024
@isidroas
Copy link

A little overlapping with #8 . IMHO I prefer sub-classing because is more specialized and easier to document.

@isidroas
Copy link

isidroas commented Nov 4, 2024

I withdraw what I've said. The function signature is so simple that it is Ok to pass it as an argument. That is more Pythonic. Similar to the first argument of filter().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:selectors enhancement New feature or request therefor
Projects
None yet
Development

No branches or pull requests

2 participants