[JW8-10570] Sync with upstream feature/v1.0.0 #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per feedback from John, the further defined response type caused issue in callers.
…rack.len (video-dev#2096) * mp4-remuxer / remuxAudio() : dont rely on track.len to compute mdatSize recompute it by looping through all samples and summing their individual size get rid of track.len as it should now be useless related to video-dev#2063
…js into playlist-loader-typescript
…cript * Playlist-loader rename. * Playlist Loader conversion to TypeScript. * Change responseType to string * Typo fix for destory -> destroy. * Change networkDetails type to "unknown".
…mport preprocess.
Fixed some typos
* Start and stop subtitle loading in sync with startLoad()/stopLoad() API calls
* Compute sliding & merge subtitle playlists during live playback
* Fix shared references between subtitle-track-controller and subtitle-stream-controller
* Refactoring:
* Extend subtitle-stream-controller from base-stream-controller
* Move more shared logic into base-stream-controller
* Move live reload interval calculation into a shared function & import into subtitle-track-controller
* Remove the trackId from subtitle fragments, and refer to them by their level property
* Several other minor refactorings (flipped conditionals, destructuring args, organizing functions)
* Add a bunch of unit tests
Fix XSS issue on metrics page reported in video-dev#2161.
stream-controller: remove inaccurate comment
Fix Istanbul reporting
which includes fix for issue with create-react-app fixes video-dev#2064
…mically (video-dev#1986) * Adding the ability for CapLevelController to be enabled/disabled dynamically. * Updating API docs to include capLevelToPlayerSize as getter/setter. * Updated documentation to further clarify capLevelToPlayerSize * Added test to ensure stop capping called when cap level controller destroyed. * Added test that nextLevelSwitch is called when we stop capping.
fix error in deploy script
File name fix `event-handler.js` to `event-handler.ts`
…bpack update webworkify-webpack to 2.1.5
Adds typing to the default HlsConfig. Additionally provides controller-based config types to use for type narrowing controller configuration to its own subset of configuration properties from the exposed public interface. Added Webpack DefinePlugin constants in their own declaration file to be used in other files as well. A test stream from video-dev#1909 started to 404, reached out to author of issue to see if we could move this stream somewhere for continued use. Esdoc plugin was required so that documentation could continue to be produced. The AST parser took issue with the object rest spreading.
…ing to flush all buffers. (video-dev#2190)
…m hls player (test update)
robwalch
changed the title
|
|
zetagame
reviewed
Sep 18, 2019
| - generate samples Box (moof and mdat) | ||
| - in charge of generating MP4 boxes | ||
| - generate Init Segment (moov) | ||
| - generate samples Box (moof and mdat) | ||
| - [src/remux/mp4-remuxer.js][] |
There was a problem hiding this comment.
Should we change this to mp4-remuxer.ts?
There was a problem hiding this comment.
good catch. I never look at this file.
zetagame
reviewed
Sep 18, 2019
| private cea608Parser?: Cea608Parser; | ||
| private lastSn: number = -1; | ||
| private prevCC: number = -1; | ||
| private vttCCs: any = null; |
There was a problem hiding this comment.
Does it make sense to specify types for vttCCs and Cues?
zetagame
reviewed
Sep 18, 2019
| // expect(removeStub).to.have.been.calledWith('video', mockSourceBuffer.video, 0, 10); | ||
| // }); | ||
| // | ||
| // it('should trigger clean back buffer when there are no pending appends', function () { |
robwalch
force-pushed
the
task/merge-v1.0.0-pre-1
branch
from
50573dc
to
26f6c8a
Compare
zetagame
approved these changes
Sep 18, 2019
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Sync LHLS branch with upstream v1.0.0 PR.
We have PR open upstream with branch feature/v1.0.0 against master:
video-dev#2370
Why is this Pull Request needed?
This is a working branch but more stable than LHLS. We should stay in sync with upstream for visibility (on both ends) into status of changes and issues.
The upstream work includes:
Are there any points in the code the reviewer needs to double check?
The merge branch restores
"version"in package.json which is not present upstream. yarn and npm errors when our build usesyarn addto modify the package.json to a commit where the package.json is technically invalid.Resolves issues:
JW8-10570