update webworkify-webpack to 2.1.5 #2174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which includes fix for issue with create-react-app fixes #2064
|
Need to make sure that this works with harmony modules. I believe that I tried |
|
Ok. 2.1.4 and 5 were only released in the last couple of days
On 13 Mar 2019, at 18:43, John Bartos <notifications@github.com<mailto:notifications@github.com>> wrote:
Need to make sure that this works with harmony modules. I believe that I tried 2.1.4 when upgrading Babel and the modules weren't working correctly.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#2174 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ADG-WesvrX00ddQA2vR2Y5lPmun6T6r_ks5vWTjcgaJpZM4bsBf->.
|
|
Ah ok, didn't know about 2.1.4 being released. Seems like this is working fine |
johnBartos
approved these changes
Mar 13, 2019
|
the tests passed in the push travis build. The other build is failing but is also showing a different commit for some reason |
This was referenced Jun 6, 2021
1 task
This was referenced Aug 13, 2022
1 task
This was referenced Nov 4, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
update webworkify-webpack to 2.1.5 which fixes the issue which is causing hls.js to crash when used with create-react-app.
Why is this Pull Request needed?
So that hls.js works with create-react-app.
Resolves issues:
fixes #2064