Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use metadata source for determining embedded 608 captions position #1048

Merged
merged 1 commit into from
Feb 3, 2016

Conversation

egreaves
Copy link
Contributor

@egreaves egreaves commented Feb 3, 2016

This addresses captions rendering issues caused by the model's static position for Live DVR streams.
metadata[source] will be used to determine the alignment position for Live DVR streams with a negative duration.
JW7-1984

…ddresses captions rendering issues caused by the model's static position for Live DVR streams. JW7-1984
@egreaves
Copy link
Contributor Author

egreaves commented Feb 3, 2016

test this please

@jwplayer-robot
Copy link

Automated tests passed!

Cheers! 🍻 👐

robwalch added a commit that referenced this pull request Feb 3, 2016
…tions-in-dvr-stream

Use metadata source for determining embedded 608 captions position
@robwalch robwalch merged commit 414fb64 into master Feb 3, 2016
@robwalch robwalch deleted the bugfix/display-correct-608-captions-in-dvr-stream branch May 4, 2016 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants