Ignore primary:flash when Flash is blocked #1558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hussam-i-am
reviewed
Nov 17, 2016
| var originalContainer = _api.getContainer(); | ||
| var parentElement = originalContainer.parentElement; | ||
| if (!parentElement) { | ||
| // couldn't perform test because setup container has not parent |
robwalch
force-pushed
the
feature/flash-blocked-detection
branch
from
a6ffd9b
to
02a3792
Compare
hussam-i-am
approved these changes
Nov 17, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
primary: 'flash'is set, andutils.flashVersion()is not 0, embed a swf during setup that calls back to confirm the Flash plugin is not blocked. If it doesn't callback in 1.5 seconds, set primary toundefinedand continue setup.The swf being embedded is a new swf called "flash.loader.swf" and is an instance of
FlashHealthCheck.as. It is < 1k in size. It's not actually loading anything - I just couldn't think of a name that described it's role that didn't sound silly or suspicious.When embedded it fills a temporary container that is styled to match the player's dimensions. This is so that any rules applied to the size of an object tag are applied (ex: a browser may block a 5x5 swf but not a 640x360 one).
JW7-3414