Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Youtube HTML5 autoplay fix [Finishes #86721652] #255

Merged
merged 3 commits into from Feb 4, 2015
Merged

Youtube HTML5 autoplay fix [Finishes #86721652] #255

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7da1905
Fixes the issue noted in #86721652 by checking if _youtubePlayer is s…
jw-kaurand Feb 4, 2015
d2e9322
Update to handle the situation where the _youtubePlayerReadyCallback …
jw-kaurand Feb 4, 2015
e291496
jshint fixes
jw-kaurand Feb 4, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
28 changes: 26 additions & 2 deletions src/js/html5/providers/jwplayer.html5.youtube.js
View file
Open in desktop
Expand Up @@ -169,6 +169,19 @@
});
}

// Returns a function that is the composition of a list of functions, each
// consuming the return value of the function that follows.
function _composeCallbacks() {
var args = arguments;
var start = args.length - 1;
return function() {
var i = start;
var result = args[start].apply(this, arguments);
while (i--) { result = args[i].call(this, result); }
return result;
};
}

function _embedYoutubePlayer(videoId, playerVars) {
if (!videoId) {
throw 'invalid Youtube ID';
Expand Down Expand Up @@ -371,10 +384,15 @@
}

if (!_youtubePlayer.getPlayerState) {
_youtubePlayerReadyCallback = function() {
var onStart = function() {
_volumeHandler();
_this.load(item);
};
if (_youtubePlayerReadyCallback) {
_youtubePlayerReadyCallback = _composeCallbacks(onStart, _youtubePlayerReadyCallback);
} else {
_youtubePlayerReadyCallback = onStart;
}
return;
}

Expand Down Expand Up @@ -416,8 +434,14 @@
if (_requiresUserInteraction) {
return;
}
if (_youtubePlayer.playVideo) {
if (_youtubePlayer && _youtubePlayer.playVideo) {
_youtubePlayer.playVideo();
} else { // If the _youtubePlayer isn't setup, then play when we're ready
if (_youtubePlayerReadyCallback) {
_youtubePlayerReadyCallback = _composeCallbacks(this.play, _youtubePlayerReadyCallback);
} else {
_youtubePlayerReadyCallback = this.play;
}
}
};

Expand Down