Controlbar fades on desktop. Doesn't fade on mobile. #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the display: table; on the jw-flag-ads since it was preventing the controller from naturally being removed when jw-flag-user-inactive was applied. It was previously there to ensure that the control bar was displayed when we calculate the position of the ad skip button, but that is now the responsibility of the skin. added a flag for mobile that will make sure that the control bar is displayed during ads. this flag toggles on and off when its mobile and we're entering instream mode. _userActivity fired at the beginning of instream mode so that the user can see the new controller state and know its an ad. !isMobile is added to _componentFadeListeners as we aren't concerned about adding mouse listeners on mobile and it caused a rare issue if the user clicks the control bar a lot during an ad where the control bar wouldn't fade away. [Finishes #97402648]
| } | ||
| } | ||
|
|
||
| .jwplayer.jw-flag-ads-mobile { |
There was a problem hiding this comment.
I'd prefer a persistent mobile or touch-screen flag on the player. Then in this case you could use:
.jwplayer.jw-flag-ads-hide-controls.jw-flag-touch-screen {
robwalch
added a commit
that referenced
this pull request
Jun 25, 2015
Controlbar fades on desktop. Doesn't fade on mobile. @jw-kaurand added 'jw-flag-touch-screen' instead of temp ads-mobile flag. [Delivers #97402648]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the display: table; on the jw-flag-ads since it was preventing the controller from naturally being removed when jw-flag-user-inactive was applied. It was previously there to ensure that the control bar was displayed when we calculate the position of the ad skip button, but that is now the responsibility of the skin.
added a flag for mobile that will make sure that the control bar is displayed during ads. this flag toggles on and off when its mobile and we're entering instream mode. _userActivity fired at the beginning of instream mode so that the user can see the new controller state and know its an ad.
!isMobile is added to _componentFadeListeners as we aren't concerned about adding mouse listeners on mobile and it caused a rare issue if the user clicks the control bar a lot during an ad where the control bar wouldn't fade away.
[Finishes #97402648]