Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RBS signatures #455

Open
HoneyryderChuck opened this issue Dec 17, 2021 · 7 comments
Open

RBS signatures #455

HoneyryderChuck opened this issue Dec 17, 2021 · 7 comments

Comments

@HoneyryderChuck
Copy link
Contributor

I've noticed that jwt doesn't ship with rbs signatures yet. Is this something the project would like to have going forward?

@anakinj
Copy link
Member

anakinj commented Dec 27, 2021

Could you describe the issue a little bit more. What are these "RBS" signatures?

@HoneyryderChuck
Copy link
Contributor Author

@excpt
Copy link
Member

excpt commented Dec 27, 2021

This looks interesting. Maybe in the future.
This isn't going to be a priority at the moment.

I am putting this on my watch list of the new things to learn.

@HoneyryderChuck
Copy link
Contributor Author

Nice. The intent of the question was to know whether you'd be interested in me contributing the sigs and perhaps dialing it in CI.

@anakinj
Copy link
Member

anakinj commented Dec 28, 2021

Ah, lol. I thought it was a cryptographic signature algorithm I've never heard of. Now it makes sense :)

@anakinj
Copy link
Member

anakinj commented Dec 28, 2021

I think that it could bring value to describe the public methods of the gem like this. The challenge maybe is to figure out what the signature actually is :). There is a lot of history.

Would appreciate a little something related to this. Maybe starting with the JWT module and decode and encode methods.

Have not bumped into this for any gems I'm familiar with. Are there some examples out there how existing gems have adapted/implemented something like this?

@autopp
Copy link

autopp commented Oct 23, 2022

I added RBS for jwt to gem_rbs_collection.
ruby/gem_rbs_collection#243

Currently, this doesn't cover all signature and some parts are untyped.
(Of course, it would be preferable if the gem itself includes RBS)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants