Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarks for user-extract #228

Closed
wants to merge 1 commit into from
Closed

Add benchmarks for user-extract #228

wants to merge 1 commit into from

Conversation

jxnl
Copy link
Collaborator

@jxnl jxnl commented Nov 26, 2023

Summary by CodeRabbit

  • Tests
    • Enhanced the testing suite with benchmarking capabilities for performance analysis.

Copy link
Contributor

coderabbitai bot commented Nov 26, 2023

Walkthrough

The update introduces a benchmarking feature to a test function, allowing for performance measurement of a specific code block. This is achieved by adding a new parameter to the function and wrapping the targeted code within an inner function that is then benchmarked. The primary functionality of the test, which involves making a call to a chat completion method and asserting the response, remains intact.

Changes

File Path Change Summary
.../test_extract_users.py Added a benchmark parameter to test_extract and implemented benchmarking for the client.chat.completions.create call.

🐇✨
To measure the time it takes,
A rabbit hops with careful stakes.
In tests, we now can see,
How fast our code can truly be. 🚀
🐇✨


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between ef70801 and 2659871.
Files ignored due to filter (2)
  • poetry.lock
  • pyproject.toml
Files selected for processing (1)
  • tests/openai/evals/test_extract_users.py (2 hunks)
Additional comments: 1
tests/openai/evals/test_extract_users.py (1)
  • 32-49: > Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [21-47]

The changes to introduce benchmarking with the benchmark parameter and the run function encapsulation are correctly implemented. Ensure that the benchmark parameter is provided by the test framework and that any necessary setup or imports for benchmarking are present elsewhere in the codebase.

@jxnl jxnl closed this Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant