Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test ollama and litellm #326

Merged
merged 2 commits into from
Jan 6, 2024
Merged

test ollama and litellm #326

merged 2 commits into from
Jan 6, 2024

Conversation

jxnl
Copy link
Collaborator

@jxnl jxnl commented Jan 5, 2024

No description provided.

@mrpher
Copy link

mrpher commented Jan 6, 2024

👏 👏

@jxnl jxnl marked this pull request as ready for review January 6, 2024 14:43
@jxnl jxnl merged commit 0c2ea68 into main Jan 6, 2024
12 checks passed
@jxnl jxnl deleted the litellm-ollama branch January 6, 2024 14:43
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes required in documentation and comments in the new example file.

Summary:

This PR enhances the documentation for different modes in 'patching.md', introduces a new example 'run.py' for 'wrap_chatcompletion' usage, and refines function and tool call handling in 'patch.py'.

Key points:

  • Updated 'patching.md' documentation to explain different modes and their impact on chat completion parameters.
  • Added a new example file 'run.py' demonstrating the use of 'wrap_chatcompletion' function with 'MD_JSON' mode.
  • Modified 'patch.py' to adjust handling of function calls and tool calls in 'dump_message', 'retry_async', and 'retry_sync' functions.

Generated with ❤️ by ellipsis.dev

@@ -82,3 +83,64 @@ user = UserExtract.from_response(response, mode=Mode.JSON)
assert user.name.lower() == "jason"
assert user.age == 25
```

## Understanding the Chat Completion Parametsrs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo in the section title. It should be 'Understanding the Chat Completion Parameters'.

Suggested change
## Understanding the Chat Completion Parametsrs
## Understanding the Chat Completion Parameters

@darrenhinde
Copy link

Amazing work! Looking forward to using this!

jxnl added a commit that referenced this pull request Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants