CICD: Add set -e -o pipefail to ruff and mypy.
#399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Changes requested.
Something look wrong? You can customize Ellipsis by editing the ellipsis.yaml for this repository.
Generated with ❤️ by ellipsis.dev
| @@ -36,10 +36,12 @@ jobs: | |||
| python3 -m pip install -r requirements.txt | |||
| - name: Run Continuous Integration Action | |||
| run: | | |||
| set -e -o pipefail | |||
There was a problem hiding this comment.
Good job on adding set -e -o pipefail to ensure the script fails if any command fails. However, please avoid suppressing linting errors using # noqa: ARG002, # noqa: ARG003, or # noqa: B007 in the code. Instead, please fix these linting errors.
jxnl
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug I've missed out earlier that shows failure in logs but does not fail the full CI check in GitHub action because of not adding
pipefail. So if a chain of commandcmd1 | cmd 2 | cmd3fails atcmd1, the full command may still pass.Now with adding the
set -e -o pipefail, if any command in a pipeline fails, the pipeline will return a failure status.I also synced up remote CI with local pre-commit hooks, in particular on
mypysince @savarin is actively introducing gradual typing to the instructor library.In addition, I fixed a few small linting errors. Some are suppressed using
noqa, for instance in line 117 inpartialjson.py,eis unused but was not removed to keep the interface consistent with other parsing (design choice).Summary:
This PR enhances the CI/CD pipeline by ensuring pipeline failure upon any command failure and includes minor linting fixes.
Key points:
set -e -o pipefailtomypyandruffworkflows in/.github/workflows/mypy.ymland/.github/workflows/ruff.yml./examples/partial_streaming/benchmark.py,/instructor/dsl/iterable.py,/instructor/dsl/partialjson.py, and/instructor/patch.py.Generated with ❤️ by ellipsis.dev