feat: add markdown yaml input mode to optimize input tokens #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sweep: PR ReviewSweep is currently reviewing your pr... |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 7c668e0 in 1 minute and 39 seconds
More details
- Looked at
223lines of code in7files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_YXhckZ45Xh1hPqc8
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -70,6 +71,16 @@ def extract_json_from_codeblock(content: str) -> str: | |||
| return content[first_paren : last_paren + 1] | |||
|
|
|||
|
|
|||
| def extract_json_from_yaml_codeblock(content: str) -> str: | |||
There was a problem hiding this comment.
The function name extract_json_from_yaml_codeblock is misleading as it performs YAML to JSON conversion. Consider renaming it to reflect its functionality more accurately, such as convert_yaml_to_json.
|
please add documentation on YAML in patching |
|
can you add the docs in patch.md? @ellipsis-dev |
ellipsis-dev bot
added a commit
that referenced
this pull request
May 20, 2024
…to optimize input tokens);
jxnl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #654
Summary:
Introduces
MD_YAMLmode to parse YAML inputs within markdown, updating necessary files and tests to support this new functionality.Key points:
MD_YAMLmode to handle YAML inputs in markdown.instructor/client.py,instructor/function_calls.py,instructor/mode.py,instructor/process_response.py, andinstructor/retry.pyto support new mode.extract_json_from_yaml_codeblockininstructor/utils.py.MD_YAMLmode intests/llm/test_openai/test_modes.py.Generated with ❤️ by ellipsis.dev