Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed up new pydantic version #847

Merged
merged 4 commits into from
Jul 16, 2024
Merged

Fixed up new pydantic version #847

merged 4 commits into from
Jul 16, 2024

Conversation

ivanleomk
Copy link
Collaborator

@ivanleomk ivanleomk commented Jul 16, 2024

Bumped Pydantic version so that we resolve #835


🚀 This description was created by Ellipsis for commit 5cf721b

Summary:

Updated Pydantic to version 2.8.0 and removed outdated type ignore comments to resolve issue #835.

Key points:


Generated with ❤️ by ellipsis.dev

Copy link

cloudflare-workers-and-pages bot commented Jul 16, 2024

Deploying instructor with  Cloudflare Pages  Cloudflare Pages

Latest commit: b55070a
Status: ✅  Deploy successful!
Preview URL: https://ebc46148.instructor.pages.dev
Branch Preview URL: https://bump-pydantic.instructor.pages.dev

View logs

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 2b070d3 in 33 seconds

More details
  • Looked at 14 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. pyproject.toml:14
  • Draft comment:
    The update to Pydantic's version should be accompanied by updates to the documentation and tests to ensure compatibility and cover any new functionalities or changes introduced by the new version of Pydantic.
  • Reason this comment was not posted:
    Confidence of 70% on close inspection, compared to threshold of 85%.

Workflow ID: wflow_L8gB708exDMgJSu8


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

ellipsis-dev bot commented Jul 16, 2024

Skipped PR review on 8798197 because no changed files had a supported extension. If you think this was in error, please contact us and we'll fix it right away.


Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 5cf721b in 28 seconds

More details
  • Looked at 52 lines of code in 4 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. instructor/dsl/iterable.py:4
  • Draft comment:
    Please ensure that the updated Pydantic version does not introduce any breaking changes or require additional modifications in the codebase. Additionally, consider updating the documentation and tests if the library's behavior or interfaces have changed.
  • Reason this comment was not posted:
    Confidence changes required: 66%
    The PR description mentions updating the Pydantic version to resolve a specific issue and remove type ignores related to Pydantic. The changes in the files reflect the removal of the type ignore comments, which aligns with the PR's intent. However, it's crucial to ensure that the updated Pydantic version does not introduce any breaking changes or require additional modifications in the codebase. Additionally, the PR should include updates to the documentation and tests if the library's behavior or interfaces have changed.

Workflow ID: wflow_zZ0s7hW4FOUCWWsJ


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@ivanleomk ivanleomk closed this Jul 16, 2024
@ivanleomk ivanleomk reopened this Jul 16, 2024
@jxnl jxnl merged commit 0c8c030 into main Jul 16, 2024
15 of 16 checks passed
@jxnl jxnl deleted the bump-pydantic branch July 16, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants