Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor code #19

Open
4 of 6 tasks
jyn514 opened this issue Apr 23, 2019 · 1 comment
Open
4 of 6 tasks

Refactor code #19

jyn514 opened this issue Apr 23, 2019 · 1 comment

Comments

@jyn514
Copy link
Owner

jyn514 commented Apr 23, 2019 •
edited
Loading

  • Use filter function instead of lots of keyword arguments: The search_messages and print_message functions take an obscene amount of arguments, most of which are only used in one place. A lot of the logic is duplicated as well. It would be nice to have a filter function that abstracts those arguments. - done for a while now
  • The main function is ridiculously big, maybe split the parser into its own function? - done for a while now
  • Very little documentation
  • nested lambdas? really?
  • arg parsing is hacky: make text optional (defaulting to .*)? That would let everything go through argparse
  • find a way to combine the two big loops in main - done since 40560e3
@jyn514 jyn514 changed the title Use filter function instead of lots of keyword arguments Refactor code Apr 27, 2019
@jyn514 jyn514 mentioned this issue Apr 27, 2019
Closed
@jyn514
Copy link
Owner Author

jyn514 commented Apr 27, 2019 •
edited
Loading

Maybe it would make sense to have a class so I don't have to pass parameters around so much Done since <a while ago>

jyn514 added a commit that referenced this issue Apr 27, 2019
@jyn514
pass fewer arguments to search_message
ffc0cea 
addresses #19
jyn514 added a commit that referenced this issue Apr 27, 2019
@jyn514
refactor argument passing
775ba8e 
use config object instead of passing lots of keywords
use login.get_login() directly instead of globals
seperate parser into its own function

addresses #19
jyn514 added a commit that referenced this issue Sep 7, 2019
@jyn514
finally combine loops in main
40560e3 
addresses #19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jyn514