You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.
HubbleProject takes responsibility for a single initialisation of mcl (thus wasm-mcl) with its BLSSignerFactory singleton.
bls-wallet-signer bypasses this and creates BLSSigners directly and assumes repeated calls to the wasm-mcl init function will always be okay, (code-smell: "inapprorpiate intimacy").
To maintain separation of concerns, use of mcl/wasm-mcl should remain contained within HubbleProject unless really needed.
Related: "Object Orgy" regarding private key access in BLSWallet, mentioned here
The text was updated successfully, but these errors were encountered:
HubbleProject takes responsibility for a single initialisation of mcl (thus wasm-mcl) with its BLSSignerFactory singleton.
bls-wallet-signer bypasses this and creates BLSSigners directly and assumes repeated calls to the wasm-mcl init function will always be okay, (code-smell: "inapprorpiate intimacy").
To maintain separation of concerns, use of mcl/wasm-mcl should remain contained within HubbleProject unless really needed.
Related: "Object Orgy" regarding private key access in BLSWallet, mentioned here
The text was updated successfully, but these errors were encountered: