Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

Return responsibility of mcl/wasm-mcl usage to HubbleProject #8

Closed
jzaki opened this issue Aug 23, 2021 · 0 comments · Fixed by #9
Closed

Return responsibility of mcl/wasm-mcl usage to HubbleProject #8

jzaki opened this issue Aug 23, 2021 · 0 comments · Fixed by #9

Comments

@jzaki
Copy link
Owner

jzaki commented Aug 23, 2021

HubbleProject takes responsibility for a single initialisation of mcl (thus wasm-mcl) with its BLSSignerFactory singleton.
bls-wallet-signer bypasses this and creates BLSSigners directly and assumes repeated calls to the wasm-mcl init function will always be okay, (code-smell: "inapprorpiate intimacy").
To maintain separation of concerns, use of mcl/wasm-mcl should remain contained within HubbleProject unless really needed.

Related: "Object Orgy" regarding private key access in BLSWallet, mentioned here

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant