-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data isn't visualized for small values #6
Comments
Ya, thats true i added a rounding since for my benchmarks the decimals were just annoying ;) If not i was thinking about something like when the values are bigger then a certain threshold (lets say 10) then do the rounding otherwise don't. |
Generally speaking, why round at all? These small differences might be important and people might not have the possibility or the time (a proper benchmark could take days) to redo the benchmark with a different scale. |
For me the main benefit is of having the visualizer is cutting through the noise and seeing the most important thing as easy as possible by not being distracted by un-important things! Just wanna check if you are aware on changing the unit and if so, what are your reasons! |
I understand that. But regardless if you want to round I'd recommend rounding to sig figs. Like on the graph 2 sig figs should be sufficient and when hovering over the data 4 are a good choice I think. To illustrate, here is a small table:
Or in scientific notation (which really illustrates the way of rounding):
There should be methods somewhere in the internet that do that rounding. |
Along with the 0.5.1 version i disabled rounding for datasets where each score was below a certain threshold. Please give it a try and let me know how you like it! |
I typically prefer the sample benchmark over the throughput one. However results are usually around below 1 ms/op. The graph then shows all values as zeros. Decimal values should be supportted in graphing!
Example json: https://gist.github.com/BrainStone/1ec997aaf3cbd07ac925bd6e66d9bcfb
The text was updated successfully, but these errors were encountered: