Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify tighter version on pdfjs-dist in package.json #65

Closed
mattddean opened this issue Jul 20, 2021 · 1 comment
Closed

Specify tighter version on pdfjs-dist in package.json #65

mattddean opened this issue Jul 20, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@mattddean
Copy link

Thought the package-lock.json file contains the correct version, the version pattern for pdfjs-dist allows for a version of pdfjs-dist that seems to rename the es5 directory to legacy. Thus, an error is thrown when this package is used as a dependency of another project without that dependent project explicitly setting its pdfjs-dist version to 2.7.570

Please update:

"pdfjs-dist": "^2.7.570"

to

"pdfjs-dist": "~2.7.570"
@k-yle
Copy link
Owner

k-yle commented Jul 28, 2021

thanks for the report, I've fixed this in #58. As of v1.1.1 we pin dependencies to prevent this from happening again

@k-yle k-yle closed this as completed Jul 28, 2021
@k-yle k-yle added the bug Something isn't working label Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants