Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create methods in Genre and MusicAlbum classes #29

Merged
merged 18 commits into from
Sep 12, 2023

Conversation

K0ppai
Copy link
Owner

@K0ppai K0ppai commented Sep 12, 2023

Hello @batoolfatima2135,
I've worked on the following in this pull request,

  • Implement methods:
    • add_item method in the Genre class
      • should take an instance of the Item class as an input
      • should add the input item to the collection of items
      • should add self as a property of the item object (by using the correct setter from the item object)
    • can_be_archived?() in the MusicAlbum class
      • should override the method from the parent class
      • should return true if parent's method returns true AND if on_spotify equals true
      • otherwise, it should return false
  • Add unit tests for all implemented methods.

Copy link
Collaborator

@batoolfatima2135 batoolfatima2135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @K0ppai,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

✅ All linters are passing
✅ Great work fixing the bug

Cheers, and Happy coding!👏👏👏

@K0ppai K0ppai merged commit f236098 into develop Sep 12, 2023
2 checks passed
@K0ppai K0ppai deleted the create_methods_in_Genre_and_MusicAlbum branch September 12, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants