Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/create options for music album and genre #33

Merged
merged 13 commits into from
Sep 12, 2023

Conversation

K0ppai
Copy link
Owner

@K0ppai K0ppai commented Sep 12, 2023

Hello @batoolfatima2135,
I've worked on the following in this pull request,

  • The following options should be available:
    • List of games
    • List all authors (e.g. 'Stephen King')
    • Add a game

Copy link
Collaborator

@batoolfatima2135 batoolfatima2135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Team

APPROVED 🟢

Highlights

✔️ item class
✔️ no rubocop error

Great implementation of all the requirements in this milestone. 👏

We have done an amazing job 👍_

Our this part is complete! There is nothing else to say other than... it's time to merge it. :shipit:

Congratulations! 🎉

CHEERS AND HAPPY CODING!👏👏👏

@K0ppai K0ppai merged commit f199e78 into develop Sep 12, 2023
2 checks passed
@K0ppai K0ppai deleted the feature/create_options_for_MusicAlbum_and_Genre branch September 12, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants