-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/create options for music album and genre #33
Merged
K0ppai
merged 13 commits into
develop
from
feature/create_options_for_MusicAlbum_and_Genre
Sep 12, 2023
Merged
Feature/create options for music album and genre #33
K0ppai
merged 13 commits into
develop
from
feature/create_options_for_MusicAlbum_and_Genre
Sep 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ps://github.com/K0ppai/My-Catalog into feature/create_options_for_MusicAlbum_and_Genre
batoolfatima2135
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Team
APPROVED 🟢
Highlights
✔️ item class
✔️ no rubocop error
Great implementation of all the requirements in this milestone. 👏
We have done an amazing job 👍_
Our this part is complete! There is nothing else to say other than... it's time to merge it.
Congratulations! 🎉
CHEERS AND HAPPY CODING!👏👏👏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @batoolfatima2135,
I've worked on the following in this pull request,