Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add method to remove an album from the list #42

Closed
wants to merge 6 commits into from

Conversation

K0ppai
Copy link
Owner

@K0ppai K0ppai commented Sep 13, 2023

Hello @batoolfatima2135 & @sunga12,
I've worked on the following in this pull request,

  1. Add a remove_album method in the MusicAlbumManager class
  2. Add an option for the remove_album method in main.rb

Copy link
Collaborator

@sunga12 sunga12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @K0ppai

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Image

Highlight ✅

  • Delete feature is working fine ✔️

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


def remove_album
loop do
puts "Choose id of the album..\n"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[OPTIONAL}

The album has a different id specified in the item class so I suggest changing the prompt to something like

puts "Which album do you want to delete?"
or
puts "Choose a number corresponding to the album"

Copy link
Collaborator

@batoolfatima2135 batoolfatima2135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @K0ppai

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlight ✅

  • Delete feature is working fine ✔️
  • no linter errors

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

@K0ppai K0ppai closed this Sep 13, 2023
@K0ppai K0ppai deleted the feature/add_new_feature branch September 13, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants