-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add method to remove an album from the list #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @K0ppai
Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉
Highlight ✅
- Delete feature is working fine ✔️
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
lib/Music/music_album_manager.rb
Outdated
|
||
def remove_album | ||
loop do | ||
puts "Choose id of the album..\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[OPTIONAL}
The album has a different id specified in the item class so I suggest changing the prompt to something like
puts "Which album do you want to delete?"
or
puts "Choose a number corresponding to the album"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @K0ppai
Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉
Highlight ✅
- Delete feature is working fine ✔️
- no linter errors
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
…y-Catalog into feature/add_new_feature
Hello @batoolfatima2135 & @sunga12,
I've worked on the following in this pull request,
remove_album
method in theMusicAlbumManager
classremove_album
method inmain.rb