Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vet clinic database: add 'join table' for visits #4

Merged
merged 3 commits into from
Aug 17, 2023

Conversation

K0ppai
Copy link
Owner

@K0ppai K0ppai commented Aug 17, 2023

Dear Reviewers,
I've worked on the following in this pull request,

  1. Create a table named vets
  2. Create a "join table" called specializations
  3. Create a "join table" called visits
  4. Insert the required data for vets
  5. Insert the required data for specializations
  6. Insert the required data for visits
  7. Write queries to answer questions

Screenshot of the queries' results

queries_results

Copy link

@AbelG101 AbelG101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @K0ppai 👋,

Your project is complete! There is nothing else to say other than... it's time to merge it.
Congratulations! 🎉 🥳🥇

Highlights

  • DB Schema is properly updated with new tables ✔
  • All data is correctly added ✔
  • Great query organization ✔
  • Correct use of Git Flow ✔
  • Descriptive PR title with a great summary ✔

Optional suggestions

  • N/A

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@K0ppai K0ppai merged commit c188408 into develop Aug 17, 2023
@K0ppai
Copy link
Owner Author

K0ppai commented Aug 17, 2023

Thanks for the review @AbelG101.

@K0ppai K0ppai deleted the feature/join_tables_visit branch August 21, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants