Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k3d delete fails when cluster has custom name #54

Closed
nunix opened this issue May 17, 2019 · 8 comments
Closed

k3d delete fails when cluster has custom name #54

nunix opened this issue May 17, 2019 · 8 comments

Comments

@nunix
Copy link

nunix commented May 17, 2019

first of all, incredible piece of software and being the WSL Corsair I had to test it on ... WSL 😈

everything works just fine, however if I create a cluster with a custom name (i.e. k3d create --name wslk3d), then when running k3d delete without any name, it will delete the $HOME/.config/k3d directory, but not delete the cluster itself (see screenshot below)
image

In the screenshot there's also the workaround mkdir -p $HOME/.config/k3d/<cluster name>

Hope this helps and really looking forward to play with it ⭐️

@andyz-dev
Copy link
Contributor

Appreciate the bug report @nunix

Which version of k3d are you running? you can get it from k3d --version.

Any chance you can try to build k3d from the tip of master and try again? There were some refactoring in this area. I was not able reproduce this with a master build. I am on MACos, but this does not look to be a platform specific issue...

@iwilltry42
Copy link
Member

Thanks for opening the issue.
I'll try to reproduce this on WSL tomorrow. We'll also have a non-dev release soon 👍

@nunix
Copy link
Author

nunix commented May 17, 2019

thanks a lot for the prompt feedback, again it's minor bug (in my eyes), nothing that blocks us.

the version is 1.1.0
image

looking really forward to test it more 👍

@andyz-dev
Copy link
Contributor

@nunix, I was able to replicate it with version 1.1.0 as well. The issue should have been fixed on the master. @iwilltry42 will make a release soon.

With v1.1.0, there is an easier work around: 'k3d delete --all'

@nunix
Copy link
Author

nunix commented May 17, 2019

oh ok perfect, will “play” with it a lot more during kubecon 😁
thanks again for the support, really helpful 🙌

If needed/wanted this case can be closed or I will close upon new release with a last screenshot confirming the fix

@iwilltry42
Copy link
Member

Just released v1.2.0, you may want to try it with this one 👍
Easy installation via: wget -q -O - https://raw.githubusercontent.com/rancher/k3d/master/install.sh | bash

@nunix
Copy link
Author

nunix commented May 19, 2019

thanks a lot for the fast action.
So now, it doesn't throw errors anymore, however even I run k3d delete --name cluster-name it doesn't delete it.
The fix k3d delete --all does work just fine 😄
image

ps: installing new version without caring about the old is always welcome ⭐️

UPDATE:
ok, when I run k3d delete --name="cluster-name" it actually works.
image

All good for me, don't know if you want to change the help on the command, or if this is "still" a bug.
In any case, for this particular bug, it's resolved and I will close it.

Thanks a lot for the prompt help, I will be using it during KubeCon 💯

UPDATE 2:
Ok, apologies ... it's 7am and going to Barcelona so my brain is not totally functional ... I did a typo wLs instead of wsL ... 😢
So the command totally works as intended.
Thanks a lot

@nunix nunix closed this as completed May 19, 2019
@iwilltry42
Copy link
Member

Haha, no worries, I also didn't catch the typo in your screenshots 😁
Glad that it works now :) Thanks a lot for your feedback and maybe we'll meet at the KubeCon 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants