Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using deprecated functions from k8s.io/apimachinery/pkg/util/wait #9321

Closed
brandond opened this issue Jan 31, 2024 · 10 comments
Closed
Assignees
Labels
kind/good-first-issue Good for newcomers kind/upstream-issue This issue appears to be caused by an upstream bug priority/high

Comments

@brandond
Copy link
Member

Upstream kubernetes deprecated several of the wait.Poll functions in 1.27.

Once 1.26 is end-of-life, we should replace all use of deprecated functions with the suggested 1.27+ replacements, and backport that change to all active branches.

@brandond brandond added the kind/upstream-issue This issue appears to be caused by an upstream bug label Jan 31, 2024
@brandond brandond added this to the v1.30.0+k3s1 milestone Jan 31, 2024
@brandond brandond added the kind/good-first-issue Good for newcomers label Jan 31, 2024
@willdot
Copy link
Contributor

willdot commented Feb 2, 2024

I'd like to take this on if that's ok?

@brandond
Copy link
Member Author

brandond commented Feb 2, 2024

Sure! Note that we don't want to this until after the final 1.26 release, which should be in February I believe. Although upstream sometimes gives us bonus releases if there are regressions or vulns. So basically until after a month has gone by with no 1.26 patch.

@willdot
Copy link
Contributor

willdot commented Feb 2, 2024

That's no problem, I'm just looking for things to get stuck into when I get some free time :)

@willdot
Copy link
Contributor

willdot commented Mar 1, 2024

Guessing this still can't be completed due to a 1.26 release 2 weeks ago?

@brandond
Copy link
Member Author

brandond commented Mar 1, 2024

Yeah, we'll have to see if we get a 1.26 release in March. If not, then we can move forward with this.

@willdot
Copy link
Contributor

willdot commented May 7, 2024

The last 1.26 release was 14th March so it’s been over a month now.

https://github.com/kubernetes/kubernetes/releases/tag/v1.26.15

@brandond
Copy link
Member Author

brandond commented May 7, 2024

Yeah, maybe we can do this for June. We are likely not doing anything additional for May due to delays in updating some of our frameworks to 1.30.

@vhespanha
Copy link

Can i take this?

@brandond
Copy link
Member Author

Not moving to to-test since this is all tech debt / dropping deprecated internal function calls and there is nothing for QA to validate.

@ShylajaDevadiga
Copy link
Contributor

Closing issue as QA is not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/good-first-issue Good for newcomers kind/upstream-issue This issue appears to be caused by an upstream bug priority/high
Projects
Archived in project
Development

No branches or pull requests

7 participants