Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-1.24] CLI + Config Enhancement #7407

Merged
merged 2 commits into from
May 2, 2023

Conversation

dereknola
Copy link
Contributor

Proposed Changes

Backports of:

Types of Changes

CLI Fixes

Verification

See linked issues

Testing

Linked Issues

#7406
#7405

User-Facing Change

* `--tls-sans` now accepts multiple arguments: `--tls-sans="foo,bar"`
* `prefer-bundled-bin: true` now works properly when set in `config.yaml.d` files

Further Comments

* Add helper function for multiple arguments in stringslice

Signed-off-by: Derek Nola <derek.nola@suse.com>

* Cleanup server setup with util function

Signed-off-by: Derek Nola <derek.nola@suse.com>
* Enable FindString to search dotD config files
* Address multiple arg cases

Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola dereknola requested a review from a team as a code owner May 2, 2023 18:58
@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Patch coverage: 46.15% and project coverage change: +0.12 🎉

Comparison is base (957536b) 9.80% compared to head (020cb99) 9.92%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.24   #7407      +/-   ##
===============================================
+ Coverage          9.80%   9.92%   +0.12%     
===============================================
  Files               149     149              
  Lines             10871   10887      +16     
===============================================
+ Hits               1066    1081      +15     
- Misses             9583    9584       +1     
  Partials            222     222              
Flag Coverage Δ
unittests 9.92% <46.15%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cli/server/server.go 0.00% <0.00%> (ø)
pkg/configfilearg/parser.go 74.53% <75.00%> (-0.47%) ⬇️
pkg/util/client.go 25.00% <100.00%> (+25.00%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dereknola dereknola merged commit b865512 into k3s-io:release-1.24 May 2, 2023
10 checks passed
@dereknola dereknola deleted the cli_consolidate_124 branch May 8, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants