-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable FindString to search dotD config files #7323
Conversation
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #7323 +/- ##
==========================================
+ Coverage 19.30% 19.42% +0.11%
==========================================
Files 81 81
Lines 5459 5472 +13
==========================================
+ Hits 1054 1063 +9
- Misses 4183 4185 +2
- Partials 222 224 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
* Enable FindString to search dotD config files * Address multiple arg cases Signed-off-by: Derek Nola <derek.nola@suse.com>
* Enable FindString to search dotD config files * Address multiple arg cases Signed-off-by: Derek Nola <derek.nola@suse.com>
* Enable FindString to search dotD config files * Address multiple arg cases Signed-off-by: Derek Nola <derek.nola@suse.com>
* Handle multiple arguments with StringSlice flags (#7380) * Add helper function for multiple arguments in stringslice Signed-off-by: Derek Nola <derek.nola@suse.com> * Cleanup server setup with util function Signed-off-by: Derek Nola <derek.nola@suse.com> * Enable FindString to search dotD config files (#7323) * Enable FindString to search dotD config files * Address multiple arg cases Signed-off-by: Derek Nola <derek.nola@suse.com> --------- Signed-off-by: Derek Nola <derek.nola@suse.com>
* Handle multiple arguments with StringSlice flags (#7380) * Add helper function for multiple arguments in stringslice * Cleanup server setup with util function Signed-off-by: Derek Nola <derek.nola@suse.com> * Enable FindString to search dotD config files (#7323) * Enable FindString to search dotD config files * Address multiple arg cases Signed-off-by: Derek Nola <derek.nola@suse.com>
Proposed Changes
FindString
now correctly searches for a CLI argument inside of theconfig.yaml.d
folderTypes of Changes
CLI Bug Fix
Verification
Create a config folder setup:
/etc/rancher/k3s/config.yaml
and/etc/rancher/k3s/config.yaml.d/test.yaml
test.yaml
fill withprefer-bundled-bin: true
Testing
New Unit test clause
Linked Issues
#7316
User-Facing Change
Further Comments