Handle multiple arguments with StringSlice flags #7380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
brandond
reviewed
Apr 28, 2023
Signed-off-by: Derek Nola <derek.nola@suse.com>
brandond
requested changes
Apr 28, 2023
Signed-off-by: Derek Nola <derek.nola@suse.com>
brandond
approved these changes
May 1, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #7380 +/- ##
==========================================
+ Coverage 19.31% 19.45% +0.14%
==========================================
Files 81 81
Lines 5458 5448 -10
==========================================
+ Hits 1054 1060 +6
+ Misses 4182 4168 -14
+ Partials 222 220 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
briandowns
approved these changes
May 2, 2023
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
May 2, 2023
* Add helper function for multiple arguments in stringslice Signed-off-by: Derek Nola <derek.nola@suse.com> * Cleanup server setup with util function Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
May 2, 2023
* Add helper function for multiple arguments in stringslice Signed-off-by: Derek Nola <derek.nola@suse.com> * Cleanup server setup with util function Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
May 2, 2023
* Add helper function for multiple arguments in stringslice Signed-off-by: Derek Nola <derek.nola@suse.com> * Cleanup server setup with util function Signed-off-by: Derek Nola <derek.nola@suse.com>
This was referenced May 2, 2023
dereknola
added a commit
that referenced
this pull request
May 2, 2023
* Handle multiple arguments with StringSlice flags (#7380) * Add helper function for multiple arguments in stringslice Signed-off-by: Derek Nola <derek.nola@suse.com> * Cleanup server setup with util function Signed-off-by: Derek Nola <derek.nola@suse.com> * Enable FindString to search dotD config files (#7323) * Enable FindString to search dotD config files * Address multiple arg cases Signed-off-by: Derek Nola <derek.nola@suse.com> --------- Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
that referenced
this pull request
May 2, 2023
* Handle multiple arguments with StringSlice flags (#7380) * Add helper function for multiple arguments in stringslice * Cleanup server setup with util function Signed-off-by: Derek Nola <derek.nola@suse.com> * Enable FindString to search dotD config files (#7323) * Enable FindString to search dotD config files * Address multiple arg cases Signed-off-by: Derek Nola <derek.nola@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
SplitSliceStringwhich allows SliceString flags like--tls-santo accept not only repeated arguments (e.g.--tls-san=foo --tls-san=bar) but also multliple comma separated args (e.g.--tls-san="foo,bar")Types of Changes
CLI
Verification
See linked issue.
Testing
2 New unit tests
Linked Issues
#7365
User-Facing Change
Further Comments