Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFC reading should only be enabled on real terminal devices #46

Closed
blarz opened this issue Sep 19, 2019 · 5 comments
Closed

NFC reading should only be enabled on real terminal devices #46

blarz opened this issue Sep 19, 2019 · 5 comments

Comments

@blarz
Copy link
Contributor

blarz commented Sep 19, 2019

NFC tag reading is enabled on terminals and pseudo-terminals (SSH...).
This messes up everything as soon as somebody logs in via SSH.
This blocks the device.

@blarz
Copy link
Contributor Author

blarz commented Sep 19, 2019

Fixed with #47 for now. Not the most elegant way, but the same hack as in the old matomat ;)

@blarz blarz closed this as completed Sep 19, 2019
@chca42
Copy link
Contributor

chca42 commented Sep 22, 2019

Hm, I see several issues with this hack, e.g., when testing nfc-code, which would now require to run it in tty1. Instead, I would favor a command-line switch, which explicitly enabled nfc, e.g. when run as a service on tty1. If there is no severe argument against it, I will implement it when migrating the terminal to a systemd-based service.

@chca42 chca42 reopened this Sep 22, 2019
@blarz
Copy link
Contributor Author

blarz commented Sep 23, 2019

You're absolutely right, hardcoding this makes testing very hard... I was too focused on fixing the issue here.

We could make it a config option? An optional "nfctty" option, which could be left empty.
What do you think?

@blarz
Copy link
Contributor Author

blarz commented Oct 3, 2019

See #51 for an interim solution until the systemd thing is deployed.

@blarz
Copy link
Contributor Author

blarz commented Oct 10, 2019

See #55 for the argparse version

@chca42 chca42 closed this as completed Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants