-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NFC reading should only be enabled on real terminal devices #46
Comments
Fixed with #47 for now. Not the most elegant way, but the same hack as in the old matomat ;) |
Hm, I see several issues with this hack, e.g., when testing nfc-code, which would now require to run it in tty1. Instead, I would favor a command-line switch, which explicitly enabled nfc, e.g. when run as a service on tty1. If there is no severe argument against it, I will implement it when migrating the terminal to a systemd-based service. |
You're absolutely right, hardcoding this makes testing very hard... I was too focused on fixing the issue here. We could make it a config option? An optional "nfctty" option, which could be left empty. |
See #51 for an interim solution until the systemd thing is deployed. |
See #55 for the argparse version |
NFC tag reading is enabled on terminals and pseudo-terminals (SSH...).
This messes up everything as soon as somebody logs in via SSH.
This blocks the device.
The text was updated successfully, but these errors were encountered: