Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test whether an engine opened successfully #42

Closed
GoogleCodeExporter opened this issue Mar 24, 2015 · 4 comments
Closed

Test whether an engine opened successfully #42

GoogleCodeExporter opened this issue Mar 24, 2015 · 4 comments

Comments

@GoogleCodeExporter
Copy link

Hi Arsen,

I came across an issue related to engine-specific parameters you introduced
in r1079 -- many thanks. If a plugin needs some parameters from config, it
must be initialized in mrcp_engine_virtual_open(), not in
mrcp_plugin_create(). But the server does not care whether the
initialization was successful or not. You should check the return value in
mrcp_server.c:632.

Thanks.
- Vali

Original issue reported on code.google.com by tomas.valenta@speechtech.cz on 14 Sep 2009 at 2:27

@GoogleCodeExporter
Copy link
Author

Hi Vali,
I completely agree, return value must be checked and I'll have closer look at 
this
issue hopefully soon.
Thanks,
Arsen.

Original comment by achalo...@gmail.com on 14 Sep 2009 at 4:37

  • Changed state: Accepted
  • Added labels: Type-Defect, Priority-Medium, OpSys-All, Component-Server, Component-Plugin

@GoogleCodeExporter
Copy link
Author

Hi Vali,
I addressed this issue in r1125, but seemed to forget update the status here.
Briefly, I added internal state to engine (is_open), which indicates whether 
engine
has been successfully opened or not. In any case engine remains in the table, 
but
will not be used if open method fails.

Original comment by achalo...@gmail.com on 18 Sep 2009 at 3:23

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author

Hi Arsen,
sorry for a little delay. Thank you for the patch, works as expected. Verified.
Cheers
- Vali

Original comment by tomas.valenta@speechtech.cz on 21 Sep 2009 at 9:31

@GoogleCodeExporter
Copy link
Author

Thanks

Original comment by achalo...@gmail.com on 5 Oct 2009 at 4:29

  • Changed state: Verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant