Skip to content
This repository has been archived by the owner on Aug 22, 2022. It is now read-only.

Remove appVersion in Chart.yaml #6

Closed
onedr0p opened this issue Apr 8, 2020 · 3 comments
Closed

Remove appVersion in Chart.yaml #6

onedr0p opened this issue Apr 8, 2020 · 3 comments

Comments

@onedr0p
Copy link
Member

onedr0p commented Apr 8, 2020

@billimek how do you feel if we remove this field from the Chart.yaml? It seems like the field is useless for a bunch of applications that do not require a chart update when a image is updated.

My line of thinking is that the command helm list --all-namespaces -a, or the helm-exporter is not returning the correct appVersion if we update the image. That makes this metadata wrong.

Of-course the proper way to handle this is to release a new chart version on every image update, but we don't really have the time to do that since new versions get released all the time, almost daily.

@onedr0p onedr0p changed the title appVersion in Chart.yaml Remove appVersion in Chart.yaml Apr 8, 2020
@billimek
Copy link
Member

It's a good question. I know that the helm chart default template now creates the following in the sample deployment template:

image: "{{ .Values.image.repository }}:{{ .Chart.AppVersion }}"

This essentially ties the image tag to the AppVersion in Chart.yaml which I think would break automation like flux. So I personally don't care for that approach.

It does seem like appVersion is extraneous. Is it a required field?

@onedr0p
Copy link
Member Author

onedr0p commented May 28, 2020

@billimek is it required field, I remember trying to remove it and the CI complaining about it.

@billimek billimek transferred this issue from billimek/billimek-charts Aug 29, 2020
@billimek billimek transferred this issue from another repository Aug 29, 2020
@onedr0p
Copy link
Member Author

onedr0p commented Aug 30, 2020

Closing this issue.

@onedr0p onedr0p closed this as completed Aug 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants