Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification: which config options are required and which not? #1268

Closed
micw opened this issue Apr 21, 2024 · 2 comments
Closed

Clarification: which config options are required and which not? #1268

micw opened this issue Apr 21, 2024 · 2 comments
Labels

Comments

@micw
Copy link
Contributor

micw commented Apr 21, 2024

Hello,

I have been playing around a bit with multus. The example configuration in https://github.com/k8snetworkplumbingwg/multus-cni/blob/master/deployments/multus-daemonset.yml looks like that:

    {
      "name": "multus-cni-network",
      "type": "multus",
      "capabilities": {
        "portMappings": true
      },
      "delegates": [
        {
          "cniVersion": "0.3.1",
          "name": "default-cni-network",
          "plugins": [
            {
              "type": "flannel",
              "name": "flannel.1",
                "delegate": {
                  "isDefaultGateway": true,
                  "hairpinMode": true
                }
              },
              {
                "type": "portmap",
                "capabilities": {
                  "portMappings": true
                }
              }
          ]
        }
      ],
      "kubeconfig": "/etc/cni/net.d/multus.d/multus.kubeconfig"
    }

I saw that the resulting generated file in the filesystemwith multus 4.0.2 looks quite different:

  1. the structure is different,top level elements are "cniVersion", "name" and "plugins".
  2. The "kubeconfig" entry is auto-created under "plugins". If has always the value passed via command line argument "multus-kubeconfig-file-host" (or it's default), regardless of the value in the configmap
  3. "plugins/capabilities" seems also to be auto-generated, regardless of the value in the configmap

So my question is, is the config file in the yaml still in an up-to-date format? Are the enties like "capabilities" or "kubeconfig" required (or even used)? If not, it would make sense to update the example config.

@dougbtv
Copy link
Member

dougbtv commented Jun 6, 2024

Copy link

github-actions bot commented Sep 5, 2024

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Sep 5, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants